From: sternenseemann <sternenseemann@systemli•org>
To: Linus Heckemann <git@sphalerite•org>, depot@tvl.su
Subject: Re: [PATCH] fix(tvix/eval): allow negative substring lengths
Date: Fri, 2 Jun 2023 15:02:10 +0200 [thread overview]
Message-ID: <367effc8-45fc-8074-3480-cb8b4894ac3a@systemli.org> (raw)
In-Reply-To: <20230601192258.1159372-1-git@sphalerite.org>
On 6/1/23 21:22, Linus Heckemann wrote:
> Nix uses string::substr without checking the sign of the length[1].
> The NixOS testing infrastructure relies on this[2], and on the
> implicit conversion of that to the maximum possible value for a
> size_t.
>
> [1]: https://github.com/NixOS/nix/blob/ecae62020b64914d9859a71ce197d03688c6133c/src/libexpr/primops.cc#L3597
> [2]: https://github.com/NixOS/nixpkgs/blob/c7c298471676ac1c7789ab3c424fbcebecaa6791/nixos/lib/testing/driver.nix#L29
Proposed as <https://cl.tvl.fyi/8692> and added my comments there. You
should be able to sign in with GitHub (at least according to
https://github.com/keycloak/keycloak/issues/9429#issuecomment-1568241222)
and comment there.
next prev parent reply other threads:[~2023-06-02 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 19:22 Linus Heckemann
2023-06-02 13:02 ` sternenseemann [this message]
2023-06-02 13:07 ` Vincent Ambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=367effc8-45fc-8074-3480-cb8b4894ac3a@systemli.org \
--to=sternenseemann@systemli$(echo .)org \
--cc=depot@tvl.su \
--cc=git@sphalerite$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://code.tvl.fyi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).